Skip to content

Angular SPA - add styles.css (Bootstrap) #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2023
Merged

Angular SPA - add styles.css (Bootstrap) #89

merged 2 commits into from
Sep 5, 2023

Conversation

@OwenRichards1
Copy link
Collaborator

@OwenRichards1 OwenRichards1 commented Sep 5, 2023 •
edited
Loading

Purpose

Add CSS styling (using bootstrap) to Angular SPA tutorial.

  • ...

Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[X] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone https://github.com/Azure-Samples/ms-identity-docs-code-javascript.git
cd angular-spa
npm install
npm start

What to Check

Please verify pulling profile information works.

  • ...

@OwenRichards1
Copy link
Collaborator Author

OwenRichards1 commented Sep 5, 2023

assign-reviewer: @cilwerner

cilwerner
cilwerner approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@cilwerner cilwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw your earlier screenshot. Happy

@OwenRichards1 OwenRichards1 changed the title creating-styling Angular SPA - add styles.css (Bootstrap) Sep 5, 2023
@cilwerner cilwerner merged commit 5253e4e into Azure-Samples:main Sep 5, 2023
@OwenRichards1 OwenRichards1 deleted the angular-spa-styling-updates branch September 5, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cilwerner cilwerner cilwerner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OwenRichards1 @cilwerner